Vim Tips Wiki
Advertisement

Use this page to discuss script 1343 1343

  • Add constructive comments, bug reports, or discuss improvements (see the guideline).
  • Do not document the script here (the author should do that on vim.org).
  • This page may be out of date: check the script's vim.org page above, and its release notes.

Comments

In rev, 1.9, line 88 should be:

if size is None:

--Preceding unsigned comment added by 75.36.191.118 00:04, February 23, 2010


I have not used the script but had a quick look. The Python code is:

    size = getattr(st, 'st_size', None)
    if not size:                             # (line 88)
	self.__diag("Could not stat tags file %s" % tagsFile)
	return None

If getattr() fails it returns None which is detected by "if not size". Looks good. JohnBeckett 01:14, February 23, 2010 (UTC)

I just noticed the edit summary for the above comment and I now see what is meant: If the tags file happens to be empty, getattr() will return zero which the original code would regard as an error. JohnBeckett 02:30, February 23, 2010 (UTC)

The above fix is incorporated in rev 1.10.

Advertisement